Skip to content

actions artifacts api list/download check status upload confirmed #34273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

actions artifacts api list/download check status upload confirmed #34273

wants to merge 4 commits into from
+81 −7

Conversation

ChristopherHX
Copy link
Contributor

  • fixes a fixture status to upload confirmed
  • add another fixture as noise to break tests as soon they are exposed to api
  • v4 delete test added check that artifact is no longer visible in internal api with status pending delete
  • removal of http 404 on empty list: actions/upload-artifact@v4 now backoff on http 404 of ListArtifacts endpoint
  • fixes artifacts with pending delete etc. are able to be found and downloaded if the storage is not freed

@ChristopherHX
actions artifacts internal api list/download check status upload conf…
7668923 
…irmed

* fixes a fixture status to upload confirmed
* add another fixture as noise to break tests as soon they are exposed to api
* v4 delete test added check that artifact is no longer visible in internal api with status pending delete
@ChristopherHX
remove duplicate
fc1e675
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 23, 2025
delvh
delvh reviewed Apr 23, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2025
@lunny lunny added this to the 1.24.0 milestone Apr 24, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh left review comments

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristopherHX @lunny @denyskon @delvh @GiteaBot