Default to creating pull request for base repository on file edit #34239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When editing the default branch and there is a base repository, make the default commit choice creating a new branch. * When creating the pull request, default compare it against the base repository default branch. This matches the behavior of creating a pull request based on a branch elsewhere in the UI. This makes it easier to do the right thing for contributing changes from a fork.
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Apr 19, 2025
| redirectToPullRequest = true | ||
| baseBranch = repo.BaseRepo.DefaultBranch | ||
| headBranch = repo.Owner.Name + "/" + repo.Name + ":" + headBranch | ||
| repo = repo.BaseRepo | ||
| } else if repo.UnitEnabled(ctx, unit.TypePullRequests) { | ||
| redirectToPullRequest = true |
There was a problem hiding this comment.
I don't quite understand the change, and it doesn't match the comment "// Redirect to a pull request when possible" above now.
Please add more comments for the details and it's better to have some tests to clarify the behavior.
There was a problem hiding this comment.
I added some comments now.
Note that whether or not it redirects to the pull request is not changed by this. Just which repository and branch is the default choice in the pull request.
For testing I'll have a look later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to do the right thing for contributing changes from a fork.