Skip to content

support the open-icon of folder #34168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang April 10, 2025 03:04
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 10, 2025
@wxiaoguang

This comment was marked as outdated.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 10, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 10, 2025
@kerwin612
Copy link
Member Author

I think we need to decouple the "basic theme" and "material theme"

According to your suggestion, I've newly submitted two commits. I'm not sure if they achieve the decoupling you mentioned.

…eeEntry` to `FileEntry` to decouple it from `git.TreeEntry`.

This change will allow integrating the file icons of the file tree on the diff page into the unified rendering logic without relying on `git.TreeEntry`.
@wxiaoguang

This comment was marked as outdated.

@wxiaoguang wxiaoguang marked this pull request as draft April 13, 2025 12:19
@kerwin612 kerwin612 marked this pull request as ready for review April 16, 2025 01:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2025
@wxiaoguang

This comment was marked as resolved.

@wxiaoguang wxiaoguang removed their request for review April 22, 2025 07:11
@wxiaoguang wxiaoguang marked this pull request as draft April 22, 2025 15:58
@kerwin612 kerwin612 marked this pull request as ready for review April 28, 2025 11:00
@kerwin612 kerwin612 requested a review from a team April 28, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants