auto generate additional ssh keys #33974
Open
+283
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows storing different keys
GiteaBot
added
the
lgtm/need 2
rework keygen to guess the keysize from extension
make key generation happen in generation module
github-actions
bot
added
the
modifies/cli
wxiaoguang
reviewed
Mar 24, 2025
wxiaoguang
reviewed
Mar 24, 2025
wxiaoguang
reviewed
Mar 24, 2025
TheFox0x7
force-pushed
the
generate-additional-ssh-keys
branch
from
0372c4b to
61f4962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds capabilities for gitea to generate ecdsa and ed25519 keys by default
adds cli for built-in ssh keygen
closes: #33783
Since we already generate RSA key in rootless by default, I see no reason to add keygen in there. Instead we can add more keygen capabilities to internal ssh server.
The only remaining question is how to expose this to end user?
One option I see is to extend ServerHostKeys to
["gitea.rsa","gitea.ecdsa","gitea.ed25519","gogs.rsa"]but I'm not sure if it's a correct way.