Remove HasWiki method and use IsRepositoryExist

[lunny]

No description provided.

[wxiaoguang]

I think it should stop here.

The design is wrong.

You can't make every function do "for repo" and "for wiki".

Since wiki is also a git repo, it should share the same repo interface as a code repo.

dismiss

[lunny]

last call @go-gitea/technical-oversight-committee

[wxiaoguang]

Is it possible to have a better design to avoid filling the code base with a lot of if err != nil { return err }? This simple PR +119 −44, in the future there will be more if err != nil { return err } and does it make code more readable or maintainable?

[lunny]

Maybe we have two options. One is to store the presence of the wiki in the repo_unit table and retrieve the information from the database each time. The other is to creating a HasWiki function under services/wiki, handle the error internally within this function, and return the result accordingly.

[wxiaoguang]

And I believe we should introduce a better error handling framework.

[wxiaoguang]

For this PR, I do not see why Remove HasWiki method makes sense or brings benefit.

I do not see any feasible plan for the "git repo" related refactoring work.

[lunny]

For this PR, I do not see why Remove HasWiki method makes sense or brings benefit.

I do not see any feasible plan for the "git repo" related refactoring work.

This PR will try to make all other packages just depend on the relative path of the repository except gitrepo package. Now the absolute repository path will be used everywhere which will prevent abstract of repository storage.

[wxiaoguang]

which will prevent abstract of repository storage.

Most of your "abstract of repository storage" PRs are still incomplete. I do not see any feasible plan.

[lunny]

which will prevent abstract of repository storage.

Most of your "abstract of repository storage" PRs are still incomplete. I do not see any feasible plan.

The first step is to move all absolute repository paths into the gitrepo package, so that other packages will only reference repository paths relative to it. Since this involves extensive changes, I plan to break the work into multiple pull requests to make review easier.

Currently, absolute repository paths are used everywhere, which makes proper abstraction difficult.

I have updated proposal #29033 with more details about this plan.

[wxiaoguang]

I have been tired of your infeasible plans, buggy code and stale PRs. So don't ask me to review.

[wxiaoguang]

And, what is #29073, are we living in parallel universes ........

[lunny]

And, what is #29073, are we living in parallel universes ........

Sorry, it's #29033