win64/clang+msvc: Skip failing tests and mark flaky test as hopeful #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfm Are you good with this change? |
|
Yes ... it's a poor substitute for someone with access to a win64/clang+msvc system diagnosing/fixing, but I agree that it's better than just leaving it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of NSURL-related tests fail or crash on 64-bit windows when compiled with the msvc front-end for clang, causing CI to be red.
This PR marks the failing tests as hopeful and skips the crashing tests altogether.
#367 tracks the root cause, but this hopefully gets CI back go green for now.