Skip to content

New layout for account creation screens #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

iuricmp
Copy link
Collaborator

@iuricmp iuricmp commented Jul 30, 2025

Redesign account creation screens to improve user experience and navigation. Introduce new components for better validation feedback.

Screenshot 2025-08-04 at 20 41 35

@iuricmp iuricmp marked this pull request as ready for review August 4, 2025 23:42
@iuricmp iuricmp requested review from jefft0 and D4ryl00 August 4, 2025 23:42
@jefft0
Copy link
Collaborator

jefft0 commented Aug 6, 2025

Need actual messages:

description: 'A short, complete sentence that takes up first, second and third line of the paragraph',
image: require('../../../assets/images/icon.png') // TODO: Replace with real asset
},
{
title: 'Feature',
description: 'Another screen with GKM description for user to let him understand what this app is about',
image: require('../../../assets/images/icon.png') // TODO: Replace with real asset
},
{
title: 'Feature 2',
description: 'Another screen with GKM description for user to let him understand what this app is about',
image: require('../../../assets/images/icon.png') // TODO: Replace with real asset

Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators.

@D4ryl00

This comment was marked as resolved.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 6, 2025

Simulator Screenshot - iPhone 16 - 2025-08-06 at 11 46 23

The button label to update the account is weird, why Update account 2?

@D4ryl00

This comment was marked as resolved.

@D4ryl00

This comment was marked as resolved.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 6, 2025

Proposition:

When you create a new account, the chain selected in the main screen is the same chain for user creation:
https://www.loom.com/share/caaf8a40b3b849b0827ffa9a63a193bd

Copy link
Collaborator

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 6, 2025

This is an issue when creating a new account. If you select a chain then you come back to "no user registration", you cannot anymore create your account. https://www.loom.com/share/7a8ec51e014b4b05be26cb970560bc96

This issue is still present.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 6, 2025

In the latest commit, make ios returns this error:

views/index.ts:2:15 - error TS2307: Cannot find module './new-vault/new-vault-view' or its corresponding type declarations.

2 export * from './new-vault/new-vault-view'

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 12, 2025

Proposition:

When you create a new account, the chain selected in the main screen is the same chain for user creation: https://www.loom.com/share/caaf8a40b3b849b0827ffa9a63a193bd

Did you implement that? It's not working for me.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 12, 2025

Simulator Screenshot - iPhone 16 - 2025-08-06 at 11 46 23

The button label to update the account is weird, why Update account 2?

Do you want to also rework the chain field to have a better UI/UX?

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 12, 2025

In the "New Chain" screen, you cannot see what you write in the last fields (RPC URL and Faucet URL)

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 12, 2025

Screenshot 2025-08-12 at 16 03 45

If there is an error during the account creating, there is no cross or arrow to quit this screen.

@D4ryl00
Copy link
Collaborator

D4ryl00 commented Aug 12, 2025

Screenshot 2025-08-12 at 16 06 23 In settings, if you click on the chain name, the next screen is not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants