Skip to content

Fix use after free bug in fuse release/releasedir #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

Fix use after free bug in fuse release/releasedir #4490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions xlators/mount/fuse/src/fuse-bridge.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3452,13 +3452,8 @@ fuse_release(xlator_t *this, fuse_in_header_t *finh, void *msg,

fd_close(state->fd);

fuse_fd_ctx_destroy(this, state->fd);
fd_unref(fd);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really delete the unrefing of the fd. I guess we have a ref on the fd hold by fuse that should be unrefed in fuse_release.


gf_fdptr_put(priv->fdtable, fd);

state->fd = NULL;

out:
send_fuse_err(this, finh, 0);

Expand Down Expand Up @@ -3904,13 +3899,8 @@ fuse_releasedir(xlator_t *this, fuse_in_header_t *finh, void *msg,
gf_log("glusterfs-fuse", GF_LOG_TRACE,
"finh->unique: %" PRIu64 ": RELEASEDIR %p", finh->unique, state->fd);

fuse_fd_ctx_destroy(this, state->fd);
fd_unref(state->fd);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above


gf_fdptr_put(priv->fdtable, state->fd);

state->fd = NULL;

out:
send_fuse_err(this, finh, 0);

Expand Down Expand Up @@ -7101,7 +7091,8 @@ struct xlator_fops fops;

struct xlator_cbks cbks = {.invalidate = fuse_invalidate,
.forget = fuse_forget_cbk,
.release = fuse_internal_release};
.release = fuse_internal_release,
.releasedir = fuse_internal_release};

struct xlator_dumpops dumpops = {
.priv = fuse_priv_dump,
Expand Down