Skip to content

Make ClientCapabilities.experimental field optional #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Enet4
Copy link
Contributor

@Enet4 Enet4 commented May 12, 2017

Closes #14, and should allow RLS to fix rust-lang/rls#312.

@Marwes
Copy link
Member

Marwes commented May 12, 2017

Might be more convenient to express it with #[serde(default)] since there is unlikely to be a difference between the field being absent or it being marked by null?

@Marwes Marwes merged commit 33754e5 into gluon-lang:master May 12, 2017
@Marwes
Copy link
Member

Marwes commented May 12, 2017

Published 0.9.0

@Enet4 Enet4 deleted the clientcapabilities-experimental-optional branch July 12, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "experimental" field should be optional RLS crashes in VSCode
2 participants