Don't show a slider for a "flat" dimension #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps a bit of an edge case, but currently if there's a "flat" dimension in a dataset (i.e., the shape at that index is 1) that's not the x/y (and z if you're in the volume viewer) attribute, then you'll get a slice widget with no slider (since then
high=0
and the usual set of buttons that then don't do anything. See the screenshot below.This looks/feels kinda janky (I thought the slider was broken until I realized that the dataset I was looking at was "flat"), so what I propose here is that we just put in
None
in the list of sliders for that dimension - i.e. don't show a slider.A quick sample dataset if one wants to reproduce this (run in the glue terminal):
What this currently looks like:
