Skip to content

Conversation

CyclingNinja
Copy link
Contributor

No description provided.

pyproject.toml Outdated
"qtconsole>=4.3,!=5.4.2",
"pvextractor>=0.2",
"importlib_resources>=1.3; python_version<'3.9'",
"importlib_resources>=1.3; python_version<'3.10'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"importlib_resources>=1.3; python_version<'3.10'",

no longer needed at all :D

@dhomeier dhomeier added the testing Unit tests label Aug 15, 2025
- linux: py311-test-pyqt66-all
- linux: py311-test-pyqt514
- linux: py311-test-pyqt515-lts-all
- linux: py314-test-pyqt68
Copy link
Contributor

@dhomeier dhomeier Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux: py314-test-pyqt68
- linux: py314-test-pyqt68-dev

Let's try with this one – we haven't actually set up any packages' dev versions (maybe we should?), but this will set the PIP_EXTRA_INDEX_URL needed to find shapely downloads – I'm a bit surprised that building h5py succeeded here; for glue-core at least I found both failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not push these from my phone somewhere in a waiting room... Completely missed the developer versions section below, as well as its glue-core etc. deps! So that should be moved down there of course.

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test envs are looking fine now once they are organised properly ;-)
There still is a commit merging main into this branch that I don't understand, but the PR looks mergeable.
Just remains to remove pixel_selection_mode.py with its fallback option to complete the transition to 1.23.

@dhomeier dhomeier added this to the v0.5.0 milestone Aug 20, 2025
Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the last set of suggestions, that should probably be it, thanks!

- linux: py311-test-pyqt66-all
- linux: py311-test-pyqt514
- linux: py311-test-pyqt515-lts-all
- linux: py314-test-pyqt68-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to # Test against latest developer versions... below

# Documentation build
- linux: py38-docs-pyqt514
- linux: py313-docs-pyqt514
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably run with py311 at most, but I'm not sure why we absolutely need docs built with PyQt5, and if they couldn't be 5.15 at least. Check with @astrofrog

# Test a few configurations on macOS 13 (Intel, default for py<310) and 14 (Arm)
- macos: py38-test-pyqt514-all
- macos: py310-test-pyqt514-all
Copy link
Contributor

@dhomeier dhomeier Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- macos: py310-test-pyqt514-all
- macos: py310-test-pyqt515-all

5.14 should still be available with macos-13 (there are wheels for x86_64), but since those runners are going to be retired anytime from 2-12 weeks from now, no point in switching.
5.15 wheels would seem to work for all supported Pythons on arm64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants