-
Notifications
You must be signed in to change notification settings - Fork 9
Remove support for py38 and py39 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pyproject.toml
Outdated
"qtconsole>=4.3,!=5.4.2", | ||
"pvextractor>=0.2", | ||
"importlib_resources>=1.3; python_version<'3.9'", | ||
"importlib_resources>=1.3; python_version<'3.10'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"importlib_resources>=1.3; python_version<'3.10'", |
no longer needed at all :D
1acb995
to
9b70122
Compare
4825701
to
f7f0e23
Compare
.github/workflows/ci_workflows.yml
Outdated
- linux: py311-test-pyqt66-all | ||
- linux: py311-test-pyqt514 | ||
- linux: py311-test-pyqt515-lts-all | ||
- linux: py314-test-pyqt68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- linux: py314-test-pyqt68 | |
- linux: py314-test-pyqt68-dev |
Let's try with this one – we haven't actually set up any packages' dev versions (maybe we should?), but this will set the PIP_EXTRA_INDEX_URL needed to find shapely downloads – I'm a bit surprised that building h5py succeeded here; for glue-core at least I found both failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not push these from my phone somewhere in a waiting room... Completely missed the developer versions section below, as well as its glue-core etc. deps! So that should be moved down there of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test envs are looking fine now once they are organised properly ;-)
There still is a commit merging main
into this branch that I don't understand, but the PR looks mergeable.
Just remains to remove pixel_selection_mode.py
with its fallback option to complete the transition to 1.23.
Co-authored-by: Derek Homeier <[email protected]>
7b24caf
to
547449e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the last set of suggestions, that should probably be it, thanks!
- linux: py311-test-pyqt66-all | ||
- linux: py311-test-pyqt514 | ||
- linux: py311-test-pyqt515-lts-all | ||
- linux: py314-test-pyqt68-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to # Test against latest developer versions...
below
# Documentation build | ||
- linux: py38-docs-pyqt514 | ||
- linux: py313-docs-pyqt514 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will probably run with py311 at most, but I'm not sure why we absolutely need docs built with PyQt5, and if they couldn't be 5.15 at least. Check with @astrofrog
# Test a few configurations on macOS 13 (Intel, default for py<310) and 14 (Arm) | ||
- macos: py38-test-pyqt514-all | ||
- macos: py310-test-pyqt514-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- macos: py310-test-pyqt514-all | |
- macos: py310-test-pyqt515-all |
5.14 should still be available with macos-13 (there are wheels for x86_64), but since those runners are going to be retired anytime from 2-12 weeks from now, no point in switching.
5.15 wheels would seem to work for all supported Pythons on arm64.
Co-authored-by: Derek Homeier <[email protected]>
No description provided.