Create colormap widget for reversing colormaps #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but not sure yet how to find the correct state when deserializing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new colormap control widget, which consists of a combobox + a checkable button. The combobox is populated with the colormaps in the config, together with a checkable button that allows reversing the colormap. This allows us a simple way to manage reverse colormaps without needing to handle it inside of a layer state. Note that we can get away with doing this because layer state colormaps aren't a selection callback property (as the dropdown is populated via the config instead).
Because of the two widget <--> one state item setup here, this requires its own custom echo handler (or at least I couldn't see a way around that). Also, any viewer that wants to use this will need to update its UI file. This PR makes the updates to the Qt scatter and image viewers.