Add unique class to each viewer instance #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unique identified to each viewer that will be added as a class for the root element of the
FigureWidgetin the DOM. This allows a client that can also run JS in the browser (e.g. a Vue component being used in a Solara app) an easy way to directly reference any figure(s) for a given viewer from a JS context in the browser. Note that this is a class, not an id - each view of theFigureWidgetwill have the same class. This class is accessible Python-side asviewer.unique_class.The class is constructed from a v4 UUID in order to be unique. The format of the class is
glue-plotly-<UUID>. This format has two purposes: