fix: use last focused/resized view to determine shape of BqplotImageView #475
Conversation
I think it's fine like this, if we also bump Line 26 in 1876875 Otherwise some people might get the old behaviour. |
|
We can use version 1.6.0 now (https://pypi.org/project/bqplot-image-gl/1.6.0/) |
iisakkirotko
force-pushed
the
fix-use-last-focused-resized-view-for-shape-bqplotimageview
branch
from
9625a7c to
1630099
Compare
|
Could you rebase to try and get the tests running? |
iisakkirotko
force-pushed
the
fix-use-last-focused-resized-view-for-shape-bqplotimageview
branch
from
1630099 to
7562d4a
Compare
|
@dhomeier done! |
|
@maartenbreddels: visual failure is related to astropy/astropy#17683 / widgetti/solara#990, right? |
|
Indeed |
|
Hmm, updating to solara 1.44 seems to have broken more than it fixed – any ideas what those pytest-playwright failures are? |
As mentioned in widgetti/solara#913 pytest-ipywidgets is not compatible with newer versions of pytest-playwright. We did not notice this in solara, because we pinned playwright, which seems to limit the versions of pytest-playwright to a compatible one. If we apply the same pinning as solara, we should be able to avoid this issue.
|
The last run prior to upgrading solara already was at |
|
Downgrading pytest-playwright helped, but now I hit widgetti/solara#606 - which I can not reproduce (so working on that now). |
Pull Request Template
Description
Instead of always using the lowest cid view to determine the aspect ratio / shape of a Bqplot image viewer, use the last focused / resized one.
focused_atdescribes the time that the window of that view was last focused, whileresized_atdescribes when each viewer was last resized, so this way distortion from resizing based on a view in a popout window will be fixed once the original window is brought into focus.Needs glue-viz/bqplot-image-gl#112 to work. Let me know if you need this to use the old behaviour as a fallback with previous versions of bqplot-image-gl.
TODO:
bqplot-image-glin the dependencies once feat: resize & focus tracking in view_data bqplot-image-gl#112 is released.