Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Porting case studies from pyglotaran-examples 🧪 #1425

Draft
wants to merge 15 commits into
base: staging
Choose a base branch
from

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Jan 29, 2024

This PR is intended to port over a set of curated examples - those are that are based on actual case studies (ideally with a publication to reference for details).

They will find a home in a new "examples" folder, under the "case_studies" subfolder.

In the future we will also develop "tutorials" which will also live inside the "examples" folder.

Change summary

  • Create examples/case_studies
  • Migrate the fluorescence case study

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)
  • 👌 Closes issue (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 🧪 Adds new tests for the feature (mandatory for ✨ feature and 🩹 bug fix PR's)
  • 📚 Adds documentation of the feature

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/porting/examples

@jsnel jsnel mentioned this pull request Jan 29, 2024
5 tasks
@jsnel
Copy link
Member Author

jsnel commented Jan 29, 2024

@joernweissenborn this will be the branch for the porting of the case studies from the examples, feel free to contribute here - or target the branch with PRs.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.1%. Comparing base (87f9303) to head (110a40e).
Report is 7 commits behind head on staging.

Current head 110a40e differs from pull request most recent head 936399a

Please upload reports for the commit 936399a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##           staging   #1425     +/-   ##
=========================================
+ Coverage     84.9%   85.1%   +0.2%     
=========================================
  Files           91      91             
  Lines         3740    3744      +4     
  Branches       728     728             
=========================================
+ Hits          3176    3189     +13     
+ Misses         448     443      -5     
+ Partials       116     112      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jsnel and others added 14 commits March 30, 2024 18:25
Test examples on staging/rewrite
for less CI confusion
Reduce some CI clutter, benchmarks will have to be re-created in a more meaningful way anyways post the rewrite finish.
Only global and some basic comparisons, still WIP
README contains reference to publications describing an analysis of the data
Based on the Hippius case study
Update transient absorption case study

From ported examples

Update examples and integrations tests

This commit adds a (failing) integration test
@jsnel jsnel force-pushed the porting/examples branch from 591a464 to 0313ce7 Compare March 30, 2024 17:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

stale bot commented Jul 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Lack of interest Issue went stale | cold | lack of (user) interest label Jul 1, 2024
@s-weigand s-weigand added staging Issues found in staging branch and removed Status: Lack of interest Issue went stale | cold | lack of (user) interest labels Aug 25, 2024
Copy link

stale bot commented Nov 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Lack of interest Issue went stale | cold | lack of (user) interest label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Issues found in staging branch Status: Lack of interest Issue went stale | cold | lack of (user) interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants