Skip to content

transforms: support babel6 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

transforms: support babel6 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/extract-transforms/babel-globalize2-default-into-globalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,14 @@ var esprima = require( "esprima" );

var Syntax = esprima.Syntax;

function isDefaultProperty(prop) {
return (prop.type === Syntax.Literal && prop.value === "default") ||
(prop.type === Syntax.Identifier && prop.name === "default");
}

/**
* Transform `_globalize2["default"].<fn>` (commonly generated by babel when transpiling ES6) into
* `Globalize.<fn>`.
* Transform `_globalize2["default"].<fn>` or `_globalize2.default.<fn>`
* (commonly generated by babel when transpiling ES6) into `Globalize.<fn>`.
*/
module.exports = {
test: function( node ) {
Expand All @@ -13,8 +18,7 @@ module.exports = {
node.callee.object.type === Syntax.MemberExpression &&
node.callee.object.object.type === Syntax.Identifier &&
node.callee.object.object.name === "_globalize2" &&
node.callee.object.property.type === Syntax.Literal &&
node.callee.object.property.value === "default";
isDefaultProperty(node.callee.object.property);
},

transform: function( node ) {
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
},
"peerDependencies": {
"cldr-data": ">=25",
"globalize": ">=1.1.0-rc.5"
"globalize": "^1.1.0"
},
"devDependencies": {
"babel": "^5.6.14",
"babel": "^6.3.26",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we support babel ^5.6 or 6.x, right? If so, we don't need to restrict it to 6.x only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this is devDependencies...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could have both vendored in for testing, but npm doesn't make that very easy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, it would.

@scottgonzalez, @jzaefferer, do you have any suggestions for that please? jQuery UI uses bower. Any projects doing this with npm that I could use as baseline?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleygwilliams Any suggestions? I feel like you recently had a tweet about something like this with Travis builds.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have a subdirectory with its own package.json file, that would let you install different versions of Babel in different subdirectories. the TodoMVC repo does that, there's a main package.json for the repo and then others for each example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for your comments. Since this isn't a blocker for this PR, I've moved this into #13

"chai": "1.10.x",
"cldr-data": ">=25",
"jshint": "2.6.x",
Expand Down