Implemented the media proxy and authenticated (user & token) API as env #2998
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based upon tech.lgbt's customisations of glitch-soc, see techlgbt/techlgbt@82f135b
ShadowJonathan
suggested changes
Mar 15, 2025
ShadowJonathan
approved these changes
Mar 15, 2025
There was a problem hiding this comment.
I just triple checked via irb, and you can actually do the (ENV['...'] || 5).to_i trick directly.
What i was talking about was (ENV['...']&.to_i || 5), since i thought integers do not implement .to_i, but they do.
So the current approach (minus changing &. to . again, since no nil value will bubble up from this) will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon the customisations made by tech.lgbt¹ I implemented a way of controlling the API request limits for the media proxy as well as the authenticated user and token API. The possibility of easily upping the media proxy limits helps with not getting rate limited by opening a profile's media tab or having a lot of media being dropped on the own timeline. Upping the authenticated API limits should also be more easy for the sake of API tools which would get rate-limited pretty fast otherwise.
Thanks to @ShadowJonathan for bringing the mentioned customisations to my attention and helping me out.
¹Specifically based upon this commit: techlgbt/techlgbt@82f135b