Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Runtime punycode Deprecation Error (#2662) #2673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davnotdev
Copy link

@davnotdev davnotdev commented Jan 8, 2025

Addresses #2662.

After the builtin punycode implementation was deprecated, quicktype now crashes at runtime from a deprecation error. This fix temporarily overrides whatwg-url to version ^13.0.0, the earliest version that properly uses a userspace punycode implementation.

whatwg-url is a dependency of node-fetch 2.x which is a dependency of cross-fetch. In the future, updating cross-fetch should fix the issue without having to override whatwg-url once this issue is addressed.

Also, further work should be done to update @vscode/vsce, eslint-config-canonical, and ajv These are dev dependencies, so they should not affect runtime, but are still prone to the punycode error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant