gh-566: add example on galaxy redshift distributions

[ntessore]

Description

Add an example that describes the caveats for sampling galaxy redshift distributions from a set of discrete matter or lensing shells.

Closes: #566

Changelog entry

Added: example on effective galaxy redshift distributions

[ntessore]

Rendered docs are here: https://glass--567.org.readthedocs.build/567/examples/1-basic/galaxy-redshift-distributions.html

[Saransh-cpp]

This looks good to me, thanks, @ntessore!

[paddyroddy]

A few comments

[arthurmloureiro]

Awesome!

It did take me reading the full example to understand what it was about. Maybe we could make it more clear that this example shows how the definition of the matter shells affects the final redshift distribution? I am saying this but I do not have a clear suggestion on how to make it clearer haha.

[ntessore]

It did take me reading the full example to understand what it was about. Maybe we could make it more clear that this example shows how the definition of the matter shells affects the final redshift distribution? I am saying this but I do not have a clear suggestion on how to make it clearer haha.

@arthurmloureiro Your sentence makes it clear, so I added it to the top of the notebook

[arthurmloureiro]

It's a green light from my side! Nice and clear example!

[NiallJeffrey]

There is a phrase in the text in bold:
“The redshifts assigned to each individual galaxies are completely irrelevant here. The clustering and lensing signals are fully determined by the shells.”
I’d suggest
(I) changing this to “Within a particular shell, the individual galaxy redshifts are effectively dummy variables. The clustering and lensing signals are fully determined by the definition of the shell (and these internal redshifts have no impact).”
(II) Placing this block of text as the second paragraph right at the top. My original confusion was about some slightly vague wording, but this is completely removed if this text is at the start providing clarification before the technical stuff -- with this present wording (if you agree).
The demo itself is very clear 👍

[ntessore]

Thanks @NiallJeffrey, that makes the message much clearer. Could you review again?

[NiallJeffrey]

Great 👍

[ntessore]

Thanks all!

[ntessore]

@all-contributors please add @arthurmloureiro for review

[allcontributors]

@ntessore

We had trouble processing your request. Please try again later.

[ntessore]

@all-contributors please add @NiallJeffrey for review

[allcontributors]

@ntessore

We had trouble processing your request. Please try again later.