Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update types #38

Merged
merged 4 commits into from May 3, 2024
Merged

update types #38

merged 4 commits into from May 3, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2024

@Totto16 Totto16 self-assigned this May 3, 2024
@Totto16
Copy link
Collaborator

Totto16 commented May 3, 2024

Thanks for the PR. ❤️

I'll look into it. But from the surface it seems correct, but could you add a @version 46 doc comment to the changed functions (or all those, you looked into and where fine for gnome 46) like already present on some files (e.g. here)

And those links from above can also be added to the source code, so that you can visit them directly from there.

@ghost
Copy link
Author

ghost commented May 3, 2024

  1. Removed loadSubInterfaceXML from fileUtils.d.ts since it is not actually used in fileUtils.js in any way
  2. Changed loadInterfaceXML declaration in fileUtils.d.ts to a re-export from dbusUtils.js as it is done in fileUtils.js
  3. Added links + version annotation as you asked

Copy link
Collaborator

@Totto16 Totto16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@Totto16 Totto16 merged commit 8655e35 into gjsify:main May 3, 2024
1 check passed
@ghost ghost deleted the correct-types branch May 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant