-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port some types to GNOME 46 #22
Conversation
I've started to go through my extensions; this is from the simpler ones. The more complex ones are still to come, and I expect that this PR will take a few days to complete. Opened a draft anyway to collect feedback as I go. I've added a |
@swsnr If you change the GNOME 46 comments to |
@JumpLink I've changed the annotations to your style. Not sure though, what you mean with "further" information… my idea was just to mark every type which has been scrutinized for GNOME 46, to keep track of things, and inform other people looking at this that they perhaps don't need to look at these types again. What further information should I provide? |
Wrt to #23 (comment) I've marked this as ready, because what's been corrected here can essentially already be merged as is 🙂 I'll try to make separate MRs for more complex changes. |
For example if there are comments in the original javascript source file then these can be adopted. |
See #21