Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some types to GNOME 46 #22

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Port some types to GNOME 46 #22

merged 6 commits into from
Mar 27, 2024

Conversation

swsnr
Copy link
Collaborator

@swsnr swsnr commented Mar 27, 2024

See #21

@swsnr
Copy link
Collaborator Author

swsnr commented Mar 27, 2024

I've started to go through my extensions; this is from the simpler ones. The more complex ones are still to come, and I expect that this PR will take a few days to complete. Opened a draft anyway to collect feedback as I go.

I've added a GNOME 46 comment to every type I've check to help me keep track of things. I can remove those comments are this is finished again, but perhaps it's helpful to track which types are GNOME 46 already? Perhaps it could be formalized to some degree?

@JumpLink
Copy link
Collaborator

@swsnr If you change the GNOME 46 comments to /** @version 46 */, you are welcome to leave them in 👍
Preferably with further information if you know it.

@swsnr
Copy link
Collaborator Author

swsnr commented Mar 27, 2024

@JumpLink I've changed the annotations to your style.

Not sure though, what you mean with "further" information… my idea was just to mark every type which has been scrutinized for GNOME 46, to keep track of things, and inform other people looking at this that they perhaps don't need to look at these types again. What further information should I provide?

@swsnr
Copy link
Collaborator Author

swsnr commented Mar 27, 2024

Wrt to #23 (comment) I've marked this as ready, because what's been corrected here can essentially already be merged as is 🙂

I'll try to make separate MRs for more complex changes.

@swsnr swsnr marked this pull request as ready for review March 27, 2024 19:33
@JumpLink
Copy link
Collaborator

@JumpLink I've changed the annotations to your style.

Not sure though, what you mean with "further" information… my idea was just to mark every type which has been scrutinized for GNOME 46, to keep track of things, and inform other people looking at this that they perhaps don't need to look at these types again. What further information should I provide?

For example if there are comments in the original javascript source file then these can be adopted.

@JumpLink JumpLink merged commit be36007 into gjsify:main Mar 27, 2024
@swsnr swsnr deleted the gnome-46/swsnr branch March 27, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants