Feature/tp3 support #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build.gradle spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/repository/GremlinGraphAdapter.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/GremlinSchema.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/GremlinProperty.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinCollectionPropertyMapper.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinEncodedPropertyMapper.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinLinkPropertyMapper.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinPropertyMapper.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinStandardPropertyMapper.java spring-data-gremlin-test/src/main/java/org/springframework/data/gremlin/object/jpa/repository/BaseRepositoryTest.java spring-data-gremlin-titan/src/main/java/org/springframework/data/gremlin/repository/titan/TitanGraphAdapter.java
Conflicts: build.gradle spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/query/GremlinQueryCreator.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/query/execution/AbstractGremlinExecution.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/query/execution/CollectionExecution.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/repository/GremlinGraphAdapter.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/repository/SimpleGremlinRepository.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/GremlinSchema.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/generator/DefaultSchemaGenerator.java spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/schema/property/mapper/GremlinStandardPropertyMapper.java spring-data-gremlin-orientdb/src/main/java/org/springframework/data/gremlin/repository/orientdb/OrientDBGremlinRepository.java spring-data-gremlin-tinker/src/main/java/org/springframework/data/gremlin/repository/tinker/TinkerGremlinRepository.java spring-data-gremlin-titan/src/main/java/org/springframework/data/gremlin/repository/titan/TitanGremlinRepository.java
This reverts commit fcc1a68.
…- all tests are still failing
…ollectionQuery for consistency - 17 tinker passing tests
…artTreeGremlinQuery and their parents - 32 tinker passing tests
…Name and findMapByFirstName) - 34 tinker passing tests
…t - 35 tinker passing tests
…JPA and Neo4J - 85 tinker passing tests
…exception after merge
…janus tests out of 136
…ble modules - things are broken in this project for TP3 still
…s passing when result is empty
…dcoded number - 126 passing tinker tests / 136
…remlinRepository to GremlinSchema - tinker passing tests: 128/138
…nch - janus passing tests: 129/137
…cascading.' from develop branch - janus passing tests: 127/137
… passing tests: 125/142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I had sent you on fb too. I tried to make everything possible to make spring-data-gremlin tests run again with TP3. Most of them pass although there are a few issues with Dynamic Vertices and cascade collections due to setCurrentLocation causing a 6th edge to be added for some annotation systems. Most probably the issue is due to LinkVia annotations of currentLocation adding duplicates. If possible please have a look - I hope janusgraph community will be able to help after I replaced decommissioned titan with janusgraph JanusGraph/janusgraph#212. Thank you!