Support hardware-backed SSH commit signing (FIDO2, PIV, ssh-agent)#2982
Open
swork9 wants to merge 4 commits into
Open
Support hardware-backed SSH commit signing (FIDO2, PIV, ssh-agent)#2982swork9 wants to merge 4 commits into
swork9 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! In our "fun" era of supply-chain attacks, a hardware key is becoming more of a necessity than a luxury - so I implemented hardware-backed SSH commit signing by shelling out to ssh-keygen directly. It's maybe not the most elegant solution, but it's reliable and reuses the OpenSSH tooling users already trust - which is the same direction JetBrains is taking too (switching to OpenSSH): https://youtrack.jetbrains.com/issue/IJPL-143
For keys that can't be signed in-process, gitui now delegates to "ssh-keygen -Y sign" (respecting
gpg.ssh.program) - covering FIDO2, PIV, and agent-backed keys - while keeping the fast in-process path for ordinary on-disk keys, and showing a "touch your security key" hint before the blocking callI followed the checklist:
make checkwithout errors