feat: support x509 commit signing - #2844
Merged
extrawurst merged 6 commits intoJul 1, 2026
Merged
Conversation
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
3 times, most recently
from
January 23, 2026 16:08
35ef709 to
8e226dd
Compare
Contributor
Author
|
@extrawurst may you review this PR? |
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
March 2, 2026 19:55
8e226dd to
35537d5
Compare
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
March 31, 2026 21:36
35537d5 to
6d14f1a
Compare
kaden-l-nelson
force-pushed
the
feat/x509-signing-method
branch
from
June 23, 2026 00:29
6d14f1a to
4acae06
Compare
extrawurst
reviewed
Jun 23, 2026
extrawurst
left a comment
extrawurst
left a comment
Collaborator
There was a problem hiding this comment.
lgtm just a few comments
jianshanbushishan
added a commit
to jianshanbushishan/gitui
that referenced
this pull request
Sep 7, 2026
Valuable upstream changes taken: - SSH commit signing via ssh-agent and external sign binaries (gitui-org#2464) - x509 commit signing (gitui-org#2844) - GPG signing for non-HEAD reword commits (gitui-org#2959) - fix: index-out-of-bounds panic in staging apply_selection (gitui-org#2955) - fix: panic when opening submodule (gitui-org#2896) - send failure now logs instead of panicking, adapted to local StatusChanged/Unchanged events - branch names: spaces auto-convert to dashes (gitui-org#2916) - ratatui 0.30 / crossterm 0.29 / ratatui-textarea migration (ratatui-image bumped 9 -> 11 to match) - insta snapshot test infra (main.rs split into gitui.rs), snapshots regenerated for the local top-bar layout Kept local versions where they supersede upstream: - git2 0.21 migration and gix 0.86 (upstream at 0.84) - editor-at-cursor-line in diff view (superset of upstream gitui-org#2904) - mailmap cache + commit-hash search in commit_filter - unchanged-notification redraw skipping ported into Gitui main loop - Input created once in main and reused across submodule reopens Extra merge fixes: - drop .as_ref() in Layout::constraints calls: palette (via ratatui-image -> icy_sixel -> quantette) adds AsRef impls for arrays that make .as_ref() ambiguous against ratatui 0.30's generic IntoIterator parameter - ratatui pinned to 0.30.0 stack (ratatui-core 0.1.0) to match upstream's tested dependency set - image fallback test relaxed: ratatui-image 11 blends tiny upscaled images, exact source pixel color no longer appears in cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2514.
It changes the following:
I followed the checklist:
make checkwithout errors