Fixes hanging resolveExternalUri #463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
Nov 9, 2022
Comment on lines
330
to
334
| const listenerWebview = portViewProvider.onDidChangePorts(element => { | ||
| if (element === portViewProvider.portMap && tryResolve()) { | ||
| listenerWebview?.dispose(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
no need to wait for ui to update, also it doesn't matter if there's nothing running in the port, url should be returned codespaces works this way
akosyakov
force-pushed
the
gp-code/main
branch
from
38cac59 to
e3abe85
Compare
jeanp413
force-pushed
the
gp-code/main
branch
from
9bdbcee to
080c678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gitpod-io/gitpod#14248