[preview] Fix preview environment workflows #21237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete job was missing the container specification, causing 'leeway: command not found' errors. Use the same dev-environment container as the stale job. Co-authored-by: Ona <[email protected]>
Convert preview-create, deploy-gitpod, and deploy-monitoring-satellite from Docker-based actions to composite actions. This fixes GCP OIDC authentication failures caused by credential file permission issues when Docker actions mount the workspace. Docker actions run in isolated containers where the credentials file path from the host doesn't match the container's filesystem, and file permissions prevent access. Composite actions run in the same context as the job, avoiding these issues. Changes: - Convert 3 Docker actions to composite actions - Add container spec to infrastructure/install/monitoring jobs in: - build.yml - branch-build.yml - ide-integration-tests.yml - workspace-integration-tests.yml - preview-env-check-regressions.yml - Remove unused inputs (infrastructure_provider, image_repo_base, previewctl_hash) from action calls Co-authored-by: Ona <[email protected]>
Add missing container specification to delete jobs in: - ide-integration-tests.yml - workspace-integration-tests.yml - preview-env-check-regressions.yml The delete-preview action is a composite action that requires leeway, which is only available in the dev-environment container. Co-authored-by: Ona <[email protected]>
geropl
changed the title
geropl
commented
Jan 9, 2026
| npmPublishTrigger: "false" | ||
| publishToNPM: true | ||
| publishToJBMarketplace: true | ||
| npmPublishTrigger: false |
geropl
commented
Jan 9, 2026
|
|
||
| leeway build \ | ||
| -Dversion="${VERSION}" \ | ||
| -DlocalAppVersion="${VERSION}" \ |
Member
Author
There was a problem hiding this comment.
... and this was the crucial changes to make previews work again - not sure how it ever worked before 🙈
kylos101
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix preview environment workflows that were failing due to GCP OIDC authentication issues and missing
leewaycommand.Fixes CLC-2190
Root causes:
preview-create,deploy-gitpod,deploy-monitoring-satellite) couldn't access GCP credentials due to filesystem path mismatches and permission issues when running in isolated containersdelete-preview(a composite action) were missing the container specification, causingleeway: command not founderrorsSolution:
Changes
Actions converted from Docker to composite:
.github/actions/preview-create/.github/actions/deploy-gitpod/.github/actions/deploy-monitoring-satellite/Workflows updated with container specifications:
build.ymlbranch-build.ymlide-integration-tests.ymlworkspace-integration-tests.ymlpreview-env-check-regressions.ymlpreview-env-gc.ymlRelated Issue(s)
N/A - discovered during CI analysis
How to test
leeway run dev:preview🪄