Conversation
Fixes gitlab4j#1231
jmini
added a commit
to jmini/jbang-ci-test
that referenced
this pull request
Mar 5, 2025
tkruse
reviewed
Mar 5, 2025
| * @throws GitLabApiException if any exception occurs during execution | ||
| */ | ||
| public Job getJob() throws GitLabApiException { | ||
| Response response = get(Response.Status.OK, null, "job"); |
There was a problem hiding this comment.
I would recommend checking that a JOB_TOKEN was set in gitlabApi and throwing a meaningful exception if not.
tkruse
reviewed
Mar 5, 2025
| * | ||
| * <pre><code>GitLab Endpoint: GET /job</code></pre> | ||
| * | ||
| * @return a single job |
There was a problem hiding this comment.
I would recommend adding more explanation that this will only work while the CI_JOB_TOKEN is valid (while the CI job is running) or similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See documentation: https://docs.gitlab.com/api/jobs/#get-job-tokens-job
Fixes #1231