Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GKDEV-1938] Fix Bitbucket selector to append actions in pull requests #53

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

gyopiazza
Copy link
Contributor

@gyopiazza gyopiazza commented Mar 17, 2025

The "Open with GitKraken" and "Open comparison with GitKraken" links should not appear in the "Pull requests" page when there are no items.

Example link: https://bitbucket.org/<project-name>/workspace/pull-requests/

image

This PR addresses the issue by refining the target selectors, since .css-1oy5iav is too generic.

image

@gyopiazza gyopiazza requested review from miggy-e and jdgarcia March 17, 2025 18:22
@jdgarcia
Copy link
Contributor

@gyopiazza I don't want to keep this open. Can you add a description of what url this affects and how so I can test it?

Copy link
Contributor

@jdgarcia jdgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the specific word workspace is disallowed as a repo name since has a specific page/meaning in Bitbucket.
this approach is better than trying to find out all the "special" words 🤔

@jdgarcia
Copy link
Contributor

jdgarcia commented Apr 9, 2025

@gyopiazza since Miggy is out for the week feel free to merge instead of waiting

@gyopiazza gyopiazza merged commit c8b2165 into main Apr 10, 2025
1 check failed
@gyopiazza gyopiazza deleted the GKDEV-1938-actions-added-on-incorrect-pages branch April 10, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants