feat(notifications): include repository name and subject type in native Windows OS notifications - #3058
Conversation
…tive OS notification
|
@emre155 - are you able to share some before and after screenshots please 🙏 |
|
Hi @setchy! Thanks for reviewing the PR. I'm currently working from a macOS environment, so I don't have immediate access to a Windows 11 machine to capture a before/after screenshot of the native Windows Notification Center. However, the essence of the change is that previously, the If anyone with a Windows setup can pull this branch and verify the notification visuals, I'd really appreciate it! |
|
Understood, but we've had that condition there for quite some time, presumably for good (Windows) reasons... |
|
One day, we'll remember the reason for it, but for now, lgtm! |
|
Do we want the notification type in the native message?? I saw that in the code change, but not in the before and after examples. I had been wondering if that'd make it too long... |


Fixes #3026.
On Windows 11, native OS notifications previously set the notification title to an empty string, preventing users from seeing which repository a notification belonged to in the Notification Center.
This PR removes the empty-string override on Windows so that notification.repository.fullName is consistently displayed as the notification title across all operating systems. Additionally, it appends the notification subject type (e.g. PullRequest, Issue) to the body for clearer context at a glance.