Skip to content

feat(notifications): include repository name and subject type in native Windows OS notifications - #3058

Merged
afonsojramos merged 2 commits into
gitify-app:mainfrom
emre155:fix/issue-3026
Jul 27, 2026
Merged

feat(notifications): include repository name and subject type in native Windows OS notifications#3058
afonsojramos merged 2 commits into
gitify-app:mainfrom
emre155:fix/issue-3026

Conversation

@emre155

@emre155 emre155 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #3026.

On Windows 11, native OS notifications previously set the notification title to an empty string, preventing users from seeing which repository a notification belonged to in the Notification Center.

This PR removes the empty-string override on Windows so that notification.repository.fullName is consistently displayed as the notification title across all operating systems. Additionally, it appends the notification subject type (e.g. PullRequest, Issue) to the body for clearer context at a glance.

@github-actions github-actions Bot added the bug Something isn't working label Jul 20, 2026
@setchy

setchy commented Jul 20, 2026

Copy link
Copy Markdown
Member

@emre155 - are you able to share some before and after screenshots please 🙏

@setchy setchy added enhancement New feature or enhancement to existing functionality and removed bug Something isn't working labels Jul 21, 2026
@github-actions github-actions Bot added bug Something isn't working and removed enhancement New feature or enhancement to existing functionality labels Jul 21, 2026
@setchy setchy changed the title fix(notifications): include repository name and subject type in native OS notifications feat(notifications): include repository name and subject type in native Windows OS notifications Jul 21, 2026
@setchy setchy added the platform:windows Related to windows build label Jul 21, 2026
@github-actions github-actions Bot added enhancement New feature or enhancement to existing functionality and removed bug Something isn't working labels Jul 21, 2026
@emre155

emre155 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi @setchy! Thanks for reviewing the PR. I'm currently working from a macOS environment, so I don't have immediate access to a Windows 11 machine to capture a before/after screenshot of the native Windows Notification Center.

However, the essence of the change is that previously, the title field for Windows notifications was overridden with an empty string, which resulted in the repository name (notification.repository.fullName) being omitted entirely from the notification banner. By removing this Windows-specific override, the repository name will now correctly populate the notification title on Windows, bringing it to parity with how it displays on macOS and Linux. Additionally, the notification body now appends the subject type (e.g. Issue, PullRequest) for clearer context at a glance.

If anyone with a Windows setup can pull this branch and verify the notification visuals, I'd really appreciate it!

@setchy

setchy commented Jul 21, 2026

Copy link
Copy Markdown
Member

Understood, but we've had that condition there for quite some time, presumably for good (Windows) reasons...

@setchy setchy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending Windows before/after

@afonsojramos

Copy link
Copy Markdown
Member

before
image

after
image

@afonsojramos

Copy link
Copy Markdown
Member

One day, we'll remember the reason for it, but for now, lgtm!

@afonsojramos
afonsojramos merged commit ec0701c into gitify-app:main Jul 27, 2026
5 checks passed
@setchy

setchy commented Jul 27, 2026

Copy link
Copy Markdown
Member

Do we want the notification type in the native message??

I saw that in the code change, but not in the before and after examples. I had been wondering if that'd make it too long...

This was referenced Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality platform:windows Related to windows build

Development

Successfully merging this pull request may close these issues.

Add additional information to the native OS notification

3 participants