[rig-header] Update rig.ts agentic file-summary header (35bd710 → 33f6959) - #314
Conversation
Add workflow system exports: workflow, runWorkflow, currentWorkflow, phase, log, parallel, pipeline, until, WorkflowSpec, Workflow, WorkflowContext, WorkflowCall, WorkflowMeta, WorkflowEvent, WorkflowLimits, WorkflowBudget, RunWorkflowOptions, WorkflowLimitError, UntilOptions, PipelineStage. Update @last-analyzed SHA and @edit-time. Add async_hooks to @deps. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — requesting one fix for a factual inaccuracy in the new PipelineStage entry.
📋 Key Themes & Highlights
Issue
- Inaccurate parameter name in
PipelineStage: The header documents the signature as(prev,item,next)=>Promise<next>, but the third parameter in the actual type isindex: number. Usingnextimplies a continuation-style callback rather than an array index.
Positive Highlights
- ✅ Comprehensive coverage of all new workflow exports
- ✅ Clean removal of
[NEW]tags from now-stable items - ✅
async_hookscorrectly added to@deps - ✅ Compact condensing of
p.*entries improves header scannability - ✅
INV:workflow-contextinvariant note is a useful addition
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 37.2 AIC · ⌖ 4.15 AIC · ⊞ 6.3K
Comment /matt to run again
| * T:RunWorkflowOptions<I> type {args?,limits?,onEvent?,signal?} options for runWorkflow [NEW] | ||
| * T:WorkflowLimitError class thrown when WorkflowLimits are exceeded [NEW] | ||
| * T:UntilOptions type {max,noProgressRounds?} loop control for until() [NEW] | ||
| * T:PipelineStage type (prev,item,next)=>Promise<next> pipeline step [NEW] |
There was a problem hiding this comment.
[/grill-with-docs] Inaccurate signature: (prev,item,next)=>Promise<next> — the third parameter is index: number, not next.
💡 Correction
The actual type definition is:
export type PipelineStage<Previous, Item, Next> = (
previous: Previous,
item: Item,
index: number,
) => Promise<Next> | Next;Suggested header entry:
* T:PipelineStage type (prev,item,index)=>Promise<Next> pipeline step [NEW]
Using next as a parameter name implies a Node.js-style continuation callback, when it is actually a numeric array index. This will mislead authors reading the header as a primary usage reference.
Updates the agentic file-summary header in
skills/rig/rig.tsto reflect commit33f6959.What changed
The previous header (
@last-analyzed 35bd710) was missing the entire workflow orchestration system introduced in the codebase. This PR adds documentation for all new exports.New exports (
[NEW]symbols)WorkflowSpec<I,O>{meta,input,body(ctx)}Workflow<I,O>WorkflowContext<I>WorkflowCall.text()/.json()/.workflow()for agent invocation inside workflowWorkflowMeta{name,description,phases?,whenToUse?}WorkflowEventWorkflowLimits{concurrency?,maxAgents?,maxWallMs?,warnAgents?}WorkflowBudgetRunWorkflowOptions<I>{args?,limits?,onEvent?,signal?}WorkflowLimitErrorUntilOptions{max,noProgressRounds?}PipelineStageworkflow(spec)runWorkflow(wf,opts?)currentWorkflow()phase(name)log(message)parallel(tasks)pipeline(items,...stages)until(options,step)Metrics
Also updated:
@last-analyzedtag:35bd710→33f6959@edit-time:2026-07-29T10:33:46Z→2026-07-31T03:16:04Z@deps: addedasync_hooks(used byAsyncLocalStoragefor workflow context)@purpose: added "workflow orchestration"