[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #312
Merged
Merged
Conversation
Closes the call.workflow discoverability gap — the last Claude dynamic-workflow primitive without a dedicated rig sample. Every other primitive (log, budget, until, parallel, pipeline, phase, call.json/text) already had samples; nested workflow delegation via call.workflow had only docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Jul 31, 2026
pelikhan
marked this pull request as ready for review
July 31, 2026 00:04
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — the sample fits cleanly into the existing architecture. No blocking issues found.
📋 Key Themes & Highlights
Positive Highlights
- ✅ Correctly uses
WorkflowWithoutInputSpecforfullAudit(noinputfield needed on the entry-point workflow) - ✅
r?.issuesoptional chaining is accurate —call.jsonreturnsT | null, so the child workflow output is nullable - ✅
{ label }option correctly applies to bothcall.jsonandcall.workflowvia their respective options types - ✅ Closes the documented gap:
call.workflowwas the only Claude dynamic-workflow primitive with no sample - ✅ PR description includes a validation run confirming typechecks pass
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 37.1 AIC · ⌖ 4.07 AIC · ⊞ 6.3K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
call.workflow(child, args)— the rig equivalent of Claude dynamic-workflow'sworkflow(ref, args)— had no dedicated sample. Every other Claude dynamic-workflow primitive already had at least one sample:log,budget,untilparallel,pipeline,phasecall.json,call.textcall.workflowWhy this improves transfer
Someone porting a Claude dynamic workflow that composes sub-workflows via
workflow(ref, args)couldn't find a working rig example showingcall.workflow. The new sample (330-nested-workflow-composition.md) closes that gap with a short, idiomatic program that:workflowwith typedinputcall.workflow(child, { dir }, { label })Files changed
skills/rig/samples/330-nested-workflow-composition.md— new sampleValidation run
Remaining intentional differences
effort/agentType/ resume journal / worktree isolation — documented inclaude-workflow-conversion.md, not modeled in rigbudgetcounts agent calls, not tokens — documented in conversion reference