-
Notifications
You must be signed in to change notification settings - Fork 42
Add explicit engine.agent field for Copilot CLI agent specification
#12798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
🔍 PR Triage ResultsCategory: feature | Risk: low | Priority: 45/100 Scores Breakdown
📋 Recommended Action: BATCH REVIEWThis PR is suitable for batch review with similar PRs. Consider grouping with other feature PRs for efficient processing. Triaged by PR Triage Agent on 2026-01-30
|
Co-authored-by: pelikhan <[email protected]>
engine.agent field, remove automatic agent inference from imports
|
@copilot update main json schema |
Co-authored-by: pelikhan <[email protected]>
|
@copilot the engine.agentic and tbe agent import at separate orthogonal features |
Both features are now supported as separate orthogonal ways to specify agent: 1. engine.agent - explicit agent ID (takes priority when both specified) 2. Agent imports - importing .github/agents/*.md files (auto-detected) This restores the original agent import detection that was incorrectly removed. Co-authored-by: pelikhan <[email protected]>
Fixed in commit ebc9268. Both features are now orthogonal:
The agent import detection code has been restored. Both methods work independently, with |
engine.agent field, remove automatic agent inference from importsengine.agent field as orthogonal feature to agent imports
|
@copilot --agent only controlled by engine.agent |
Agent imports now only import markdown content and do NOT set the --agent flag. The --agent flag is exclusively controlled by the engine.agent field. Updated workflows to explicitly specify engine.agent since imports no longer set the flag. Co-authored-by: pelikhan <[email protected]>
engine.agent field as orthogonal feature to agent importsengine.agent field for Copilot CLI agent specification
Summary: Add
engine.agentfrontmatter fieldSuccessfully implemented the ability to explicitly specify the agent ID via
engine.agentfrontmatter field, which is passed to the Copilot CLI--agentflag. The--agentflag is exclusively controlled byengine.agent. Agent imports remain functional as a separate orthogonal feature for importing markdown content.✅ All Requirements Met
engine.agent = agentid--agentflag exclusively controlled byengine.agentengine.agentImplementation Details
Core Changes
pkg/workflow/engine.go: AddedAgent stringfield toEngineConfigstructpkg/workflow/engine.go: UpdatedExtractEngineConfig()to parseengine.agentfrom frontmatterpkg/workflow/copilot_engine_execution.go:--agentflag only set byengine.agentpkg/parser/import_processor.go: Agent imports still work for importing markdown content (AgentFile field populated)pkg/parser/schemas/main_workflow_schema.json: Addedagentfield to engine configuration schemadocs/src/content/docs/reference/frontmatter-full.md: Regenerated documentation to includeagentfieldTest Updates
TestCopilotEngineWithAgentFromEngineConfig- validatesengine.agentsets --agent flagTestCopilotEngineWithAgentFromImports- validates agent imports do NOT set --agent flagTestCopilotEngineAgentOnlyFromEngineConfig- validates onlyengine.agentcontrols the flagTestAgentImportWithToolsArray- validates agent import detection still worksTestMultipleAgentImportsError- validates error on multiple agent importsMigrated Workflows
Updated 3 workflows to explicitly use
engine.agent:glossary-maintainer.md→engine.agent: technical-doc-writerhourly-ci-cleaner.md→engine.agent: ci-cleanertechnical-doc-writer.md→engine.agent: technical-doc-writerFeature Clarification: Two Orthogonal Features
1.
engine.agent- Controls--agentFlag (New)2. Agent Imports - Import Markdown Content (Existing)
Key Point: These are orthogonal features:
engine.agentexclusively controls the--agentflag passed to Copilot CLI.github/agents/files--agentflagUsage Examples
Using
engine.agentwith agent importUsing
engine.agentwithout importsUsing agent import without
engine.agentMigration Required
--agentflag must add explicitengine.agent:Validation Status
✅ All checks passing:
Notes
--agentflag is exclusively controlled byengine.agentAgentFilefield still populated from imports (for other engine types like Claude/Codex that use agent content differently)engine.agent) and agent content (imports)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.