Handle when an alert message contains links to files outside of the repository source #2672
Merged
robertbrignull merged 3 commits intomainfrom Aug 8, 2023
Merged
Conversation
charisk
approved these changes
Aug 8, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I've not tested locally myself but the code changes make sense.
Contributor
Author
It was last week, but I did test locally, including with a message that does contain working links. I think it's all fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2622
Fixes support for MRVA using queries where a placeholder link goes to outside of the source archive. In this case we have a location without a
regionand this was causing a crash because we were naughtily assuming fields to be defined.Rendering of alerts now works and the message placeholder is rendered as a regular string instead of a link:

Use the following query to reproduce the bug and observe that it now works:
Checklist
ready-for-doc-reviewlabel there.