Maintain scroll position while a textarea is resized #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a textarea is positioned near the end of a page, we can get in a situation where we set the height of the textarea to
autobefore setting the correct height. This causes the page to shrink which effectively scrolls the page up for the user. When the textarea then expands, the user is not scrolled back down to the textarea. The user experiences this change as a scroll up movement which is unexpected for them.This pull request makes the library aware of the user scroll position and makes sure to set the scroll position to what it was before the resizing after the resizing is done.