fix(integrations): don't write an inert agent-context config when the extension is absent#2885
fix(integrations): don't write an inert agent-context config when the extension is absent#2885PascalThuet wants to merge 1 commit into
Conversation
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
We are phasing using agent context files completely and the extension will only be available as an opt-in for single agent install. We are NOT going to support it for multi install and it will be entirely an opt-in at 0.0.12. So please limit to scope to that
… extension is absent
integration install/switch/upgrade go through _update_init_options_for_integration, which wrote agent-context-config.yml whenever the config file already existed and created it from defaults otherwise, leaving projects without the extension with an inert config nothing reads. Write it only when the extension is registered (registry.is_installed("agent-context")). No install or back-fill on any path; init is unchanged.
Fixes github#2881
PascalThuet
force-pushed
the
fix/2881-agent-context-backfill
branch
from
ab5ad24 to
fc2d0a4
Compare
PascalThuet
changed the title
|
Thanks. Dropped the back-fill, so there's no auto-install on any path now. This just stops install/switch/upgrade from leaving an inert |
There was a problem hiding this comment.
Thanks for the investigation. The scenario this addresses — agent-context config written when the extension is absent — only occurs when a user upgrades the CLI but skips the documented project update step (specify init --here --force --integration <agent>). Our upgrade guide already covers this two-step process, and the worst case is an inert YAML file that causes no harm.
Additionally, agent-context is moving to fully opt-in at 0.0.12, so adding defensive infrastructure around it is working against the direction we're heading.
2 participants
Fixes #2881.
Per your review, I dropped the back-fill approach (no more auto-install on install/switch/upgrade) and cut this down to the underlying bug.
integration install/switch/upgradego through_update_init_options_for_integration, which wroteagent-context-config.ymlwhenever the config file already existed and created it from defaults otherwise. A project without the extension ended up with an inert config nothing reads. It now writes that config only when the extension is actually registered (registry.is_installed("agent-context")). Nothing gets installed or back-filled, andinitis unchanged.Tests (
pytest tests/extensions tests/integrations tests/test_agent_config_consistency.py): 2381 passed, 15 skipped. Added unit + end-to-end coverage for both cases (extension absent, extension present).Left out, can split into follow-ups:
is_installeddoesn't check theenabledflag, so a disabled-but-installed extension still gets its config updated.initstill writes the config if the extension install itself fails (pre-existing).