feat: add line range support to get_file_contents tool #351
Conversation
| @@ -15,6 +15,66 @@ automation and interaction capabilities for developers and tools. | |||
| ## Prerequisites | |||
|
|
|||
| 1. To run the server in a container, you will need to have [Docker](https://www.docker.com/) installed. | |||
|
|
|||
| ## Required Token Permissions | |||
There was a problem hiding this comment.
Please remove this section. I think it's interesting to have, but should have its own issue for discussion.
| - `owner`: Repository owner (string, required) | ||
| - `repo`: Repository name (string, required) | ||
| - `sha`: Branch name, tag, or commit SHA (string, optional) | ||
| - `path`: Only commits containing this file path (string, optional) | ||
| - `page`: Page number (number, optional) | ||
| - `perPage`: Results per page (number, optional) | ||
|
|
||
| ### Search |
There was a problem hiding this comment.
Not sure why this is moved.
| @@ -471,7 +488,39 @@ func GetFileContents(getClient GetClientFn, t translations.TranslationHelperFunc | |||
|
|
|||
| var result interface{} | |||
| if fileContent != nil { | |||
| result = fileContent | |||
| if fileContent.Content != nil && (begin > 0 || end > 0) { | |||
There was a problem hiding this comment.
I'm not sure about this implementation. Should it be possible for the LLM to only provide the beginning or the end? Whatever we choose should be documented so the LLM understands what is acceptable.
| } | ||
| } else { | ||
| result = fileContent | ||
| } | ||
| } else { | ||
| result = dirContent |
There was a problem hiding this comment.
What should happen if the LLM provides begin and end but the contents returned are dirContent? How do we communicate what is acceptable to the LLM in the description?
| @@ -471,7 +488,39 @@ func GetFileContents(getClient GetClientFn, t translations.TranslationHelperFunc | |||
|
|
|||
| var result interface{} | |||
| if fileContent != nil { | |||
| result = fileContent | |||
| if fileContent.Content != nil && (begin > 0 || end > 0) { | |||
There was a problem hiding this comment.
All of this needs to be unit tested.
| } | ||
| ranged := lines[startIdx:endIdx] | ||
| joined := strings.Join(ranged, "\n") | ||
| result = &github.RepositoryContent{ |
There was a problem hiding this comment.
It seems like we should check the .Encoding of the file content before deciding that we need to base64 encode it.
Closes: #350