Combine tools #349
Draft
Combine tools #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates various GitHub notification tools into a single ManageNotifications tool to reduce redundant tooling and simplify the API.
- Combined separate functions for marking a notification as read, marking all notifications as read, and marking a notification as done into one unified tool.
- Updated tooling registration in pkg/github/tools.go and merged logic in pkg/github/notifications.go to support action-based behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/tools.go | Registering notifications tool now using GetNotifications and ManageNotifications. |
| pkg/github/notifications.go | Consolidated and refactored notification actions into a single switch-case structure. |
| if lastReadAt != "" { | ||
| lastReadTime, err := time.Parse(time.RFC3339, lastReadAt) | ||
| switch action { | ||
| case "mark_read": |
There was a problem hiding this comment.
The 'mark_read' action does not call any API to mark a notification as read; it directly returns a success message. Please add the appropriate API call to actually mark the notification as read.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
|
Sorry for the pings. I'm going to take another look at this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👉🏼 👉🏼 Note the target branch is
notifications-tooling, notmasterFrom my previous PR into the same target branch, where I added "mark notification as done" I received the feedback to combine some of the tooling so we don't add as many tools for notification. This is my attempt to do that. Note, I definitely used
for help.
👇🏼 Previous feedback:
