Skip to content

Improve README by including config example for gh-host flag #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajbos
Copy link

@rajbos rajbos commented Apr 23, 2025

I could figure out how to configure the MCP server against GitHub Enterprise Server, but it took a couple of tries and debugging as I forgot to include the http schema in the hostname. Adding an example makes it a bit more clear in my opinion, improving the user experience of the server 😄.

@rajbos rajbos requested a review from a team as a code owner April 23, 2025 10:16
@williammartin
Copy link
Collaborator

Hey @rajbos thanks for opening this. Instead of doing this (or in addition), do you think we should adjust the server to append https:// if the scheme is unspecified?

@rajbos
Copy link
Author

rajbos commented Apr 23, 2025

Adding it automatically also works. For me it helped to be able to see the example of the extra container arguments, helpful if you do not run them all the time. So doing both would be my preference then 😁.

@williammartin
Copy link
Collaborator

Yeh I just have a minor concern because the JSON is still bifurcated between VSCode and Insiders on whether the input: prompt is supported. Maybe we could adjust this to just demonstrate an amended env block?

@rajbos
Copy link
Author

rajbos commented Apr 23, 2025

Yeh I just have a minor concern because the JSON is still bifurcated between VSCode and Insiders on whether the input: prompt is supported. Maybe we could adjust this to just demonstrate an amended env block?

I am using the input block in normal VS Code v1.99.3, so it already is available then?

@SamMorrowDrums
Copy link
Collaborator

@rajbos the issue @williammartin was referring to is that the one-click install button doesn't support setting inputs automatically for VScode (it does for insiders) so for now people are getting a configuration that has the PAT in the env block, and not as an input, but that will be fixed after the next VScode release.

@chidaozhi
Copy link

chidaozhi commented Apr 25, 2025

Could you please let me know how to config "-gh-host"?
Is this right?(use in cursor)
"args": [ "run", "-i", "--rm", "-e", "--gh-host=https://xxx.xxx.com/xxx", "GITHUB_PERSONAL_ACCESS_TOKEN", "ghcr.io/github/github-mcp-server" ],

@rajbos
Copy link
Author

rajbos commented Apr 25, 2025

Check the changes files in the PR for the example. You now have it as 'name=value', which is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants