Add list notifications tool #297
Open
+212
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a tool to list GitHub notifications, providing new endpoints and tests for retrieving notifications with customizable paging and filtering.
- Introduces a new notifications toolset in pkg/github/tools.go.
- Implements the ListNotifications handler in pkg/github/notifications.go with supporting tests in pkg/github/notifications_test.go.
- Updates pkg/github/server.go to include a new helper for optional boolean parameters and documents the change in README.md.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Adds a notifications toolset and registers it with the tool group. |
| pkg/github/server.go | Adds OptionalBoolParamWithDefault helper but contains logic issues. |
| pkg/github/notifications_test.go | Provides tests for the notifications tool functionality. |
| pkg/github/notifications.go | Implements the ListNotifications tool. |
| README.md | Updates documentation with the new notifications tool information. |
krzd
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new tool to list GitHub notifications along with its implementation, tests, and documentation updates.
- Introduces a notifications toolset with read functions.
- Implements the ListNotifications tool in the GitHub package.
- Provides tests for notifications behavior and updates the README documentation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/tools.go | Adds a new toolset for notifications with read capabilities. |
| pkg/github/notifications.go | Implements the notifications listing functionality. |
| pkg/github/notifications_test.go | Adds tests ensuring proper behavior of the notifications tool. |
| README.md | Updates documentation to include the new notifications tool details. |
Comments suppressed due to low confidence (1)
pkg/github/notifications_test.go:117
- [nitpick] Consider adding assertions for additional fields such as the URL to further improve test coverage of notification properties.
assert.Equal(t, *tc.expectedResponse[i].Subject.Title, *notification.Subject.Title)
krzd
approved these changes
Apr 23, 2025
| require.NoError(t, err) | ||
| assert.Equal(t, len(tc.expectedResponse), len(returnedNotifications)) | ||
| for i, notification := range returnedNotifications { | ||
| assert.Equal(t, *tc.expectedResponse[i].ID, *notification.ID) |
There was a problem hiding this comment.
Copilot is somewhat right here with:
[nitpick] Consider adding assertions for additional fields such as the URL to further improve test coverage of notification properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a tool to list notifications
DoL exercise to add list notifications tool for github MCP server with with @krzd, @leachj, @geramirez using copilot agent mode
Screenshots
Closes: N/A -