Add clarity to the "Build from source" option #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfearing
changed the title
rfearing
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies the "Build from source" instructions in the README by explicitly describing how to build the executable and configure the server to use it.
- Updated instructions to use "go build" instead of "go".
- Added guidance on specifying an output location via the "-o" flag along with an example JSON configuration.
|
Same/similar as/to #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on contributing to #225, I found this area of the instructions could use more clarity. Hopefully this is clearer and provides additional instructions on how to specify the output location of the build and configure the server to use the built executable.