Resolve threat detection extraction decisions#40
Open
davidslater wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves remaining Issue #26 decisions by aligning Copilot authentication naming across the spec/docs and removing the deprecated GH_AW_COPILOT_TOKEN fallback from generated Copilot container smoke workflows.
Changes:
- Updated threat detection spec and README to use
COPILOT_GITHUB_TOKENfor Copilot authentication. - Updated the sibling-workflow generator to emit only
secrets.COPILOT_GITHUB_TOKENfor Copilot env wiring. - Regenerated the Copilot container smoke lock workflow to remove the
GH_AW_COPILOT_TOKEN/GH_AW_GITHUB_TOKENfallback chain.
Show a summary per file
| File | Description |
|---|---|
specs/threat-detection-spec.md |
Renames Copilot auth variable to COPILOT_GITHUB_TOKEN in the spec’s engine auth table. |
scripts/create-threat-detection-sibling-workflows.py |
Removes Copilot secret fallback logic from generated container-detection siblings. |
README.md |
Updates Copilot auth documentation to standardize on COPILOT_GITHUB_TOKEN and removes fallback documentation. |
.github/workflows/smoke-copilot-container.lock.yml |
Applies the generator change to the compiled container smoke workflow env. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- resolve remaining issue #26 decisions for engine CLI packaging and backward compatibility\n- standardize Copilot auth docs/spec on COPILOT_GITHUB_TOKEN\n- remove GH_AW_COPILOT_TOKEN fallback from generated container smoke workflow\n\n## Validation\n- scripts/create-threat-detection-sibling-workflows.py --check\n- grep confirmed no GH_AW_COPILOT_TOKEN references outside tmp/