Skip to content

Resolve threat detection extraction decisions#40

Open
davidslater wants to merge 1 commit intomainfrom
davidslater/resolve-threat-detection-decisions
Open

Resolve threat detection extraction decisions#40
davidslater wants to merge 1 commit intomainfrom
davidslater/resolve-threat-detection-decisions

Conversation

@davidslater
Copy link
Copy Markdown
Collaborator

Summary\n- resolve remaining issue #26 decisions for engine CLI packaging and backward compatibility\n- standardize Copilot auth docs/spec on COPILOT_GITHUB_TOKEN\n- remove GH_AW_COPILOT_TOKEN fallback from generated container smoke workflow\n\n## Validation\n- scripts/create-threat-detection-sibling-workflows.py --check\n- grep confirmed no GH_AW_COPILOT_TOKEN references outside tmp/

Copilot AI review requested due to automatic review settings May 8, 2026 00:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves remaining Issue #26 decisions by aligning Copilot authentication naming across the spec/docs and removing the deprecated GH_AW_COPILOT_TOKEN fallback from generated Copilot container smoke workflows.

Changes:

  • Updated threat detection spec and README to use COPILOT_GITHUB_TOKEN for Copilot authentication.
  • Updated the sibling-workflow generator to emit only secrets.COPILOT_GITHUB_TOKEN for Copilot env wiring.
  • Regenerated the Copilot container smoke lock workflow to remove the GH_AW_COPILOT_TOKEN / GH_AW_GITHUB_TOKEN fallback chain.
Show a summary per file
File Description
specs/threat-detection-spec.md Renames Copilot auth variable to COPILOT_GITHUB_TOKEN in the spec’s engine auth table.
scripts/create-threat-detection-sibling-workflows.py Removes Copilot secret fallback logic from generated container-detection siblings.
README.md Updates Copilot auth documentation to standardize on COPILOT_GITHUB_TOKEN and removes fallback documentation.
.github/workflows/smoke-copilot-container.lock.yml Applies the generator change to the compiled container smoke workflow env.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants