[log] Add debug logging to server/middleware_auth.go#9087
Merged
Conversation
Add meaningful debug log calls to authentication middleware: - Log when auth key is configured vs. not configured in applyIfConfigured - Log auth rejection details (status, code, detail, path, remote) in rejectAuthRequest These logs help troubleshoot authentication issues by making it visible when middleware is applied and providing context on why requests are rejected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug visibility for authentication middleware setup and rejected requests.
Changes:
- Logs whether middleware configuration is applied or skipped.
- Logs authentication rejection context.
Show a summary per file
| File | Description |
|---|---|
internal/server/middleware_auth.go |
Adds authentication setup and rejection diagnostics. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
| // If key is empty the handler is returned unchanged. | ||
| func applyIfConfigured(key string, handler http.HandlerFunc, middleware func(string, http.HandlerFunc) http.HandlerFunc) http.HandlerFunc { | ||
| if key != "" { | ||
| logAuth.Print("Auth key configured, applying middleware") |
Collaborator
|
@copilot address review feedback |
Contributor
12 tasks
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 3 meaningful debug logging calls to
internal/server/middleware_auth.goto improve troubleshooting of authentication middleware.Changes
File:
internal/server/middleware_auth.goapplyIfConfigured: Log when auth middleware is applied (key configured) vs. skipped (no key configured)rejectAuthRequest: Log rejection details including HTTP status, error code, failure reason, request path, and remote addressWhy these logs are useful
Validation
go build ./internal/server/...✅go test ./internal/server/...✅go vet ./internal/server/...✅Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.