-
Notifications
You must be signed in to change notification settings - Fork 62k
Fix missing echo call for powershell #38663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks for opening a PR! I'll get this triaged for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also noticed this issue. We need it.
@Totto16 According to everyone I've talked to, all the documentation I've been able to find, and a Stack Overflow question someone unearthed for me, the Out-File cmdlet sends outputs to a file without the need for "echo." |
Oh shit, then I'm sorry, I Just thought it doesn't make sense, since a pure string as command piped into another command isn't the same as Anyway, if you can confirm, that it also works without echo, I'll close this PR, again sorry for not checking it myself and coming to the same conclusion. |
@Totto16 It's not a problem. According to Copilot (which, you know, take everything it says with a grain of salt - I started there but double-checked with multiple other people), PowerShell is unusual in this respect. I can't actually check myself because I'm on a Mac and so is most of the rest of GitHub. If you can double check that would be awesome, but if not my inquiries are still open and several actual experts have been pinged. Not sure if people are just bored on a Friday or what, but like three people jumped on this one with pings to additional people, so... 🤷♀️ |
I Just double checked it in the CI, both works (with and without echo), so I'll close this PR. Thanks for all the help. |
Why:
I found this issue, while reading the docs
What's being changed (if available, include any code snippets, screenshots, or gifs):
If you use
"<whatever>" | Out-File -FilePath "$env:GITHUB_PATH" -Append
you need to add an echo to the command before the pipe (|
)Check off the following: