Skip to content

Add hint that docker repository names (git org + git repo name) must be all lowercase #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ianfixes
Copy link

@ianfixes ianfixes commented Dec 7, 2020

The documentation fails to mention that OWNER or REPOSITORY substitution with a name that contains a capital letter will fail.

Logging in to registry docker.pkg.github.com
WARNING! Using -*** the CLI is insecure. Use --password-stdin.
WARNING! Your password will be stored unencrypted in /github/home/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
Building image [docker.pkg.github.com/Arduino-CI/action/:latest]
invalid argument "docker.pkg.github.com/Arduino-CI/action/:latest" for "-t, --tag" flag: invalid reference format: repository name must be lowercase
See 'docker build --help'.
Error: exit status 125

invalid reference format: repository name must be lowercase

see https://github.com/Arduino-CI/action/runs/1508611501#step:4:23

…be all lowercase

The documentation fails to mention that OWNER or REPOSITORY substitution with a name that contains a capital letter will fail.

see https://github.com/Arduino-CI/action/runs/1508611501#step:4:23
@welcome
Copy link

welcome bot commented Dec 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@syyedamir0007

This comment has been minimized.

@ianfixes
Copy link
Author

ianfixes commented Dec 7, 2020

As I continue to work on this, I notice docker/build-push-action#127 (comment)

docker.pkg.github.com is deprecated and will sunset early next year

Also, docker/build-push-action@v2 is wildly different from @v1.

@janiceilene
Copy link
Contributor

@ianfixes Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request to help us better understand the context of your changes, then we'll get this up for review!

@ianfixes
Copy link
Author

ianfixes commented Dec 8, 2020

I'm not sure what the issue would say except that the docs for uploading docker images are out of date and incomplete. As per my previous comment, I'm not even sure what the scope of the fix should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants