Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to document known issues related to the limitations of the reflect package. In particular, it adds a new note describing how promoted methods result in new method declarations.
- Added a limitation note for promoted methods.
- Updated the known issues section for clarity.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
| automatically stubbed. | ||
| - It cannot currently distinguish between type aliases. This is a | ||
| limitation of the `reflect` package. | ||
| - It makes new method declarations for promoted methods. This is a |
There was a problem hiding this comment.
[nitpick] The sentence about promoted methods is unclear and could be rephrased for better clarity and grammatical correctness. Consider rewording it to, for example, 'Promoted methods generate new declarations, which may lead to unexpected behavior.'
Suggested change
| - It makes new method declarations for promoted methods. This is a | |
| - Promoted methods generate new declarations, which may lead to unexpected behavior. This is a |
smowton
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.