Add explicit permissions to workflow and update action versions#28
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
A concise update to the CI workflow configuration to add explicit repository content permissions.
- Adds explicit explicit permissions for the workflow by specifying repository contents have read access.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
`setup-go` implements the same caching in newer versions, which is on by default
smowton
approved these changes
Mar 12, 2025
smowton
left a comment
There was a problem hiding this comment.
Suggest note in the title/description that you also upgrade actions and remove explicit cache ops presumably due to replacement by setup-go. Otherwise lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow was no longer functional and contained a number of issues, which this PR addresses:
setup-goimplement dependency caching themselves, so we don't have to do this ourselvespull_requestevent on PRs.