Skip to content

C++: Add more registry flow sources and COM-related flow summaries #22257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 9 commits into from
Jul 31, 2026
Merged

C++: Add more registry flow sources and COM-related flow summaries #22257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
883a814
C++: Add missing flow models.
MathiasVP Jul 30, 2026
5256b95
C++: Add models and accept test changes.
MathiasVP Jul 30, 2026
f9125b7
C++: Make "windows-registry" a subkind of local flow sources so we ca…
MathiasVP Jul 30, 2026
d1b7498
C++: Add missing flow test cases.
MathiasVP Jul 30, 2026
05c6fe3
C++: Add flow models and accept test changes.
MathiasVP Jul 30, 2026
b1867d8
C++: Respond to Copilot comments.
MathiasVP Jul 30, 2026
285e61f
C++: Fix QLDoc.
MathiasVP Jul 30, 2026
9cf4d07
C++: Remove 'StringFromGUID'.
MathiasVP Jul 30, 2026
a7c1978
C++: Remove 'StringFromGUID' model.
MathiasVP Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions cpp/ql/lib/ext/Windows.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,18 @@ extensions:
- ["", "", False, "HttpReceiveRequestEntityBody", "", "", "Argument[*3]", "remote", "manual"]
- ["", "", False, "HttpReceiveClientCertificate", "", "", "Argument[*3]", "remote", "manual"]
# winreg.h
- ["", "", False, "RegQueryValueA", "", "", "Argument[*2]", "local", "manual"]
- ["", "", False, "RegQueryValueExA", "", "", "Argument[*4]", "local", "manual"]
- ["", "", False, "RegQueryValueW", "", "", "Argument[*2]", "local", "manual"]
- ["", "", False, "RegQueryValueExW", "", "", "Argument[*4]", "local", "manual"]
- ["", "", False, "RegGetValueA", "", "", "Argument[*5]", "local", "manual"]
- ["", "", False, "RegGetValueW", "", "", "Argument[*5]", "local", "manual"]
- ["", "", False, "RegQueryValueA", "", "", "Argument[*2]", "windows-registry", "manual"]
- ["", "", False, "RegQueryValueExA", "", "", "Argument[*4]", "windows-registry", "manual"]
- ["", "", False, "RegQueryValueW", "", "", "Argument[*2]", "windows-registry", "manual"]
- ["", "", False, "RegQueryValueExW", "", "", "Argument[*4]", "windows-registry", "manual"]
- ["", "", False, "RegGetValueA", "", "", "Argument[*5]", "windows-registry", "manual"]
- ["", "", False, "RegGetValueW", "", "", "Argument[*5]", "windows-registry", "manual"]
# TODO: Once we support access paths at sources we should also mark Argument[*1].Field[*ve_valueptr]
- ["", "", False, "RegQueryMultipleValuesA", "", "", "Argument[*3]", "local", "manual"]
- ["", "", False, "RegQueryMultipleValuesA", "", "", "Argument[*3]", "windows-registry", "manual"]
# TODO: Once we support access paths at sources we should also mark Argument[*1].Field[*ve_valueptr]
- ["", "", False, "RegQueryMultipleValuesW", "", "", "Argument[*3]", "local", "manual"]
- ["", "", False, "RegQueryMultipleValuesW", "", "", "Argument[*3]", "windows-registry", "manual"]
- ["", "", False, "RegEnumValueA", "", "", "Argument[*2,*6]", "windows-registry", "manual"]
- ["", "", False, "RegEnumValueW", "", "", "Argument[*2,*6]", "windows-registry", "manual"]
- addsTo:
pack: codeql/cpp-all
extensible: summaryModel
Expand All @@ -69,4 +71,13 @@ extensions:
# winternl.h
- ["", "", False, "RtlInitUnicodeString", "", "", "Argument[*1]", "Argument[*0].Field[*Buffer]", "value", "manual"]
# winhttp.h
- ["", "", False, "WinHttpCrackUrl", "", "", "Argument[*0]", "Argument[*3]", "taint", "manual"]
- ["", "", False, "WinHttpCrackUrl", "", "", "Argument[*0]", "Argument[*3]", "taint", "manual"]
# combaseapi.h
- ["", "", False, "IIDFromString", "", "", "Argument[*0]", "Argument[*1]", "taint", "manual"]
- ["", "", False, "StringFromIID", "", "", "Argument[*0]", "Argument[**1]", "taint", "manual"]
- ["", "", False, "ProgIDFromCLSID", "", "", "Argument[*0]", "Argument[**1]", "taint", "manual"]
- ["", "", False, "CLSIDFromProgID", "", "", "Argument[*0]", "Argument[*1]", "taint", "manual"]
- ["", "", False, "CLSIDFromString", "", "", "Argument[*0]", "Argument[*1]", "taint", "manual"]
- ["", "", False, "StringFromCLSID", "", "", "Argument[*0]", "Argument[**1]", "taint", "manual"]
- ["", "", False, "GUIDFromString", "", "", "Argument[*0]", "Argument[*1]", "taint", "manual"]
- ["", "", False, "StringFromGUID2", "", "", "Argument[*0]", "Argument[*1]", "taint", "manual"]
9 changes: 9 additions & 0 deletions cpp/ql/lib/semmle/code/cpp/security/FlowSources.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ abstract class RemoteFlowSource extends FlowSource { }
/** A data flow source of local user input. */
abstract class LocalFlowSource extends FlowSource { }

/** A data flow source that represents the access of a value from the Windows registry. */
abstract class WindowsRegistrySource extends LocalFlowSource { }

/**
* A remote data flow source that is defined through a `RemoteFlowSourceFunction` model.
*/
Expand Down Expand Up @@ -101,6 +104,12 @@ private class ExternalLocalFlowSource extends LocalFlowSource {
override string getSourceType() { result = "external" }
}

private class ExternalWindowsRegistrySource extends WindowsRegistrySource {
ExternalWindowsRegistrySource() { sourceNode(this, "windows-registry") }

override string getSourceType() { result = "a value from the Windows registry" }
}

/** A remote data flow sink. */
abstract class RemoteFlowSink extends DataFlow::Node {
/** Gets a string that describes the type of this flow sink. */
Expand Down
Loading
Loading