Dataflow: Overlay informed dataflow. #20386

alexet · 2025-09-08T15:40:45Z

No description provided.

shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll

shared/dataflow/codeql/dataflow/DataFlow.qll

+    private module Stage1 = ImplStage1<C>;
+
+    import Stage1::PartialFlow
+


shared/dataflow/codeql/dataflow/DataFlow.qll

+      }
+
+      predicate observeOverlayInformedIncrementalMode() { not Config::observeDiffInformedIncrementalMode() }
+    }


shared/dataflow/codeql/dataflow/TaintTracking.qll

+  import MakeImplStage1<Location, DataFlowLang> as DataFlowInternalStage1

-  private module AddTaintDefaults<DataFlowInternal::FullStateConfigSig Config> implements
+  module AddTaintDefaults<DataFlowInternal::FullStateConfigSig Config> implements


shared/dataflow/codeql/dataflow/TaintTracking.qll


+  signature int speculationLimitSig();
+
+  module AddSpeculativeTaintSteps<


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      import DataFlowInternal::DefaultState<Config>
+      import Config

-    private predicate relevantState(Config::FlowState state) {


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      ) {
+        Config::isAdditionalFlowStep(node1, node2) and model = "Config"
+      }
+


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      import DataFlowInternal::DefaultState<Config>
+      import Config
+
+      predicate isAdditionalFlowStep(


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      import AddTaintDefaults<Config0>
    }

-    predicate isBarrierOut(DataFlowLang::Node node, FlowState state) {


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      import Config
+
+      predicate isAdditionalFlowStep(
+        DataFlowLang::Node node1, DataFlowLang::Node node2, string model


shared/dataflow/codeql/dataflow/TaintTracking.qll

+      import AddTaintDefaults<Config0>
    }
+
+    private module Stage1 = DataFlowInternalStage1::ImplStage1<C>;


…overlay aware.

Copilot

Pull Request Overview

This PR implements overlay-informed dataflow analysis capabilities for CodeQL. The changes introduce support for evaluating dataflow in overlay mode, where base and overlay database results can be merged, providing incremental analysis capabilities.

Key changes:

Added overlay-informed filtering logic that complements the existing diff-informed mode
Introduced new predicate variants for determining overlay evaluation context
Created overlay-aware modules that merge base and overlay results for dataflow and taint tracking

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
shared/util/codeql/util/AlertFiltering.qll	Added predicates to check diff information availability and file inclusion in diff ranges
shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll	Implemented overlay-informed filtering logic for sources and sinks with dual evaluation modes
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll	Added OverlayImpl module that merges base and overlay dataflow results
shared/dataflow/codeql/dataflow/TaintTracking.qll	Refactored modules and added overlay-aware taint tracking implementations
shared/dataflow/codeql/dataflow/DataFlow.qll	Split into core and overlay-specific modules with new overlay evaluation support
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowImplSpecific.qll	Added Java-specific overlay evaluation predicate implementation

Comments suppressed due to low confidence (1)

shared/dataflow/codeql/dataflow/TaintTracking.qll:1

The condition should use Config::observeOverlayInformedIncrementalMode() without negation to match the logic in the flow predicate above. Currently this will include local results when overlay mode is disabled, which contradicts the expected behavior.

/**

alexet · 2025-09-19T17:24:27Z

@aschackmull Can you have a quick look over this to check that the general codee organisation is reasonable. This is the least duplication I could come up with.

github-actions bot added Java DataFlow Library labels Sep 8, 2025

github-advanced-security bot found potential problems Sep 8, 2025

View reviewed changes

shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 8, 2025

View reviewed changes

shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll Fixed Show fixed Hide fixed

alexet force-pushed the alexet/overlay-informed-dataflow branch from 4ebfdd4 to 04e8ab6 Compare September 8, 2025 16:25

github-advanced-security bot found potential problems Sep 8, 2025

View reviewed changes

shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll Fixed Show fixed Hide fixed

alexet force-pushed the alexet/overlay-informed-dataflow branch from 04e8ab6 to 5ee86e9 Compare September 12, 2025 17:27

github-advanced-security bot found potential problems Sep 12, 2025

View reviewed changes

alexet force-pushed the alexet/overlay-informed-dataflow branch from 850a45e to 14b7523 Compare September 12, 2025 17:33

alexet added 2 commits September 19, 2025 16:14

DataFlow: Rearrange files to group the parts that can be shared with …

8305a78

…overlay aware.

AlertFiltering: Expose filtering further.

0142d94

alexet force-pushed the alexet/overlay-informed-dataflow branch from 14b7523 to c00e150 Compare September 19, 2025 15:15

alexet changed the title ~~Dataflow: Diff informed dataflow.~~ Dataflow: Overlay informed dataflow. Sep 19, 2025

DataFlow: Add code to do overlay informed dataflow.

360d32a

alexet force-pushed the alexet/overlay-informed-dataflow branch from c00e150 to 1f99e98 Compare September 19, 2025 15:27

alexet requested a review from Copilot September 19, 2025 15:42

Copilot AI reviewed Sep 19, 2025

View reviewed changes

DataFlow: Add code for merging base with overlay.

5a11aac

alexet force-pushed the alexet/overlay-informed-dataflow branch from 1f99e98 to 5a11aac Compare September 19, 2025 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dataflow: Overlay informed dataflow. #20386

Dataflow: Overlay informed dataflow. #20386

Uh oh!

alexet commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Copilot AI left a comment

Uh oh!

alexet commented Sep 19, 2025

Uh oh!

Uh oh!

		private module Stage1 = ImplStage1<C>;

		import Stage1::PartialFlow


		signature int speculationLimitSig();

		module AddSpeculativeTaintSteps<

Dataflow: Overlay informed dataflow. #20386

Are you sure you want to change the base?

Dataflow: Overlay informed dataflow. #20386

Uh oh!

Conversation

alexet commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

alexet commented Sep 19, 2025

Uh oh!

Uh oh!