Improve NestJS sources and dependency injection #19769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
reviewed
Jun 23, 2025
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Looks great so far. Currently waiting for CI checks and some performance evaluations to finish.
| or | ||
| exists(DataFlow::FunctionNode f | | ||
| f = tuple.getAPropertyWrite("useFactory").getRhs().getALocalSource() and | ||
| f = tuple.getAPropertyWrite("useFactory").getRhs().getAFunctionValue() and |
Contributor
There was a problem hiding this comment.
This change makes the predicate mutually recursive with call graph construction, which might cause some performance issues. I've started some performance evaluations to help determine how expensive it is.
asgerf
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NestJS middlewares as remote flow sources and improves dependency injection in several ways (each commit message explains what it adds support for).