Java: Add explicit @suites-based filtering in query suites

java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/missing-override-annotation
+ * @suites security-and-quality
  * @tags maintainability
  */
 

java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/deprecated-call
+ * @suites security-and-quality
  * @tags maintainability
  *       non-attributable
  *       external/cwe/cwe-477

java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/inconsistent-javadoc-throws
+ * @suites security-and-quality
  * @tags maintainability
  */
 

java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision very-high
  * @id java/unknown-javadoc-parameter
+ * @suites security-and-quality
  * @tags maintainability
  */
 

java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/jdk-internal-api-access
+ * @suites security-and-quality
  * @tags maintainability
  */
 

java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/underscore-identifier
+ * @suites security-and-quality
  * @tags maintainability
  */
 

java/ql/src/DeadCode/UselessParameter.ql

@@ -5,6 +5,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/unused-parameter
+ * @suites security-and-quality
  * @tags maintainability
  *       useless-code
  *       external/cwe/cwe-561

java/ql/src/Language Abuse/ChainedInstanceof.ql

@@ -5,6 +5,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/chained-type-tests
+ * @suites security-and-quality
  * @tags maintainability
  *       language-features
  */

java/ql/src/Language Abuse/IterableIterator.ql

@@ -7,6 +7,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/iterator-implements-iterable
+ * @suites security-and-quality
  * @tags correctness
  *       reliability
  */

java/ql/src/Language Abuse/OverridePackagePrivate.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/non-overriding-package-private
+ * @suites security-and-quality
  * @tags maintainability
  *       readability
  */

java/ql/src/Language Abuse/TypeVarExtendsFinalType.ql

@@ -7,6 +7,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/type-bound-extends-final
+ * @suites security-and-quality
  * @tags maintainability
  *       readability
  *       types

java/ql/src/Language Abuse/TypeVariableHidesType.ql

@@ -6,6 +6,8 @@
  * @problem.severity warning
  * @precision medium
  * @id java/type-variable-hides-type
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       readability
  *       types

java/ql/src/Language Abuse/UselessNullCheck.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/useless-null-check
+ * @suites security-and-quality
  * @tags maintainability
  *       useless-code
  *       external/cwe/cwe-561

java/ql/src/Language Abuse/UselessTypeTest.ql

@@ -5,6 +5,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/useless-type-test
+ * @suites security-and-quality
  * @tags maintainability
  *       language-features
  *       external/cwe/cwe-561

java/ql/src/Language Abuse/WrappedIterator.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/iterable-wraps-iterator
+ * @suites security-and-quality
  * @tags correctness
  *       reliability
  */

java/ql/src/Likely Bugs/Arithmetic/BadAbsOfRandom.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/abs-of-random
+ * @suites security-and-quality
  * @tags reliability
  *       maintainability
  */

java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql

@@ -5,6 +5,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/evaluation-to-constant
+ * @suites security-and-quality
  * @tags maintainability
  *       useless-code
  */

java/ql/src/Likely Bugs/Arithmetic/InformationLoss.ql

@@ -8,6 +8,7 @@
  * @security-severity 8.1
  * @precision very-high
  * @id java/implicit-cast-in-compound-assignment
+ * @suites security-and-quality
  * @tags reliability
  *       security
  *       external/cwe/cwe-190

java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql

@@ -6,6 +6,8 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/integer-multiplication-cast-to-long
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       types

java/ql/src/Likely Bugs/Arithmetic/LShiftLargerThanTypeWidth.ql

@@ -5,6 +5,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/lshift-larger-than-type-width
+ * @suites security-and-quality
  * @tags correctness
  */
 

java/ql/src/Likely Bugs/Arithmetic/MultiplyRemainder.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/multiplication-of-remainder
+ * @suites security-and-quality
  * @tags maintainability
  *       correctness
  */

java/ql/src/Likely Bugs/Arithmetic/RandomUsedOnce.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/random-used-once
+ * @suites security-and-quality
  * @tags reliability
  *       maintainability
  *       external/cwe/cwe-335

java/ql/src/Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/whitespace-contradicts-precedence
+ * @suites security-and-quality
  * @tags maintainability
  *       readability
  *       external/cwe/cwe-783

java/ql/src/Likely Bugs/Cloning/MissingCallToSuperClone.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @precision medium
  * @id java/missing-call-to-super-clone
+ * @suites security-and-quality
  * @tags reliability
  *       maintainability
  *       external/cwe/cwe-580

java/ql/src/Likely Bugs/Cloning/MissingMethodClone.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision medium
  * @id java/missing-clone-method
+ * @suites security-and-quality
  * @tags reliability
  *       maintainability
  */

java/ql/src/Likely Bugs/Collections/ArrayIndexOutOfBounds.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision high
  * @id java/index-out-of-bounds
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       exceptions

java/ql/src/Likely Bugs/Collections/ContainsTypeMismatch.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/type-mismatch-access
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       logic

java/ql/src/Likely Bugs/Collections/IteratorRemoveMayFail.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/iterator-remove-failure
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       logic

java/ql/src/Likely Bugs/Collections/ReadOnlyContainer.ql

@@ -5,6 +5,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/empty-container
+ * @suites security-and-quality
  * @tags reliability
  *       maintainability
  *       useless-code

java/ql/src/Likely Bugs/Collections/RemoveTypeMismatch.ql

@@ -7,6 +7,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/type-mismatch-modification
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       logic

java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql

@@ -5,6 +5,8 @@
  * @problem.severity error
  * @precision very-high
  * @id java/unused-container
+ * @suites security-and-quality
+ *         quality
  * @tags maintainability
  *       useless-code
  *       external/cwe/cwe-561

java/ql/src/Likely Bugs/Comparison/CompareIdenticalValues.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/comparison-of-identical-expressions
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       logic

java/ql/src/Likely Bugs/Comparison/CovariantCompareTo.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision medium
  * @id java/wrong-compareto-signature
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/CovariantEquals.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision medium
  * @id java/wrong-equals-signature
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/EqualsArray.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/equals-on-arrays
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/HashedButNoHash.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/hashing-without-hashcode
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql

@@ -6,6 +6,8 @@
  * @problem.severity error
  * @precision very-high
  * @id java/equals-on-unrelated-types
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/InconsistentCompareTo.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/inconsistent-compareto-and-equals
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql

@@ -6,6 +6,8 @@
  * @problem.severity error
  * @precision very-high
  * @id java/inconsistent-equals-and-hashcode
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       external/cwe/cwe-581

java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql

@@ -6,6 +6,8 @@
  * @problem.severity error
  * @precision high
  * @id java/unchecked-cast-in-equals
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  */

java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql

@@ -6,6 +6,8 @@
  * @problem.severity error
  * @precision very-high
  * @id java/reference-equality-of-boxed-types
+ * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       external/cwe/cwe-595

java/ql/src/Likely Bugs/Comparison/StringComparison.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/reference-equality-on-strings
+ * @suites security-and-quality
  * @tags reliability
  *       external/cwe/cwe-597
  */

java/ql/src/Likely Bugs/Comparison/UselessComparisonTest.ql

@@ -7,6 +7,7 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/constant-comparison
+ * @suites security-and-quality
  * @tags correctness
  *       logic
  *       external/cwe/cwe-570

java/ql/src/Likely Bugs/Comparison/WrongNanComparison.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision very-high
  * @id java/comparison-with-nan
+ * @suites security-and-quality
  * @tags correctness
  */
 

java/ql/src/Likely Bugs/Concurrency/CallsToConditionWait.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision medium
  * @id java/wait-on-condition-interface
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       concurrency

java/ql/src/Likely Bugs/Concurrency/CallsToRunnableRun.ql

@@ -6,6 +6,7 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/call-to-thread-run
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       concurrency

java/ql/src/Likely Bugs/Concurrency/DateFormatThreadUnsafe.ql

@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @precision medium
  * @id java/thread-unsafe-dateformat
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       concurrency

java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLocking.ql

@@ -6,6 +6,7 @@
  * @problem.severity error
  * @precision high
  * @id java/unsafe-double-checked-locking
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       concurrency

java/ql/src/Likely Bugs/Concurrency/DoubleCheckedLockingWithInitRace.ql

@@ -8,6 +8,7 @@
  * @problem.severity warning
  * @precision high
  * @id java/unsafe-double-checked-locking-init-order
+ * @suites security-and-quality
  * @tags reliability
  *       correctness
  *       concurrency